[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14050: Fwupd Backend For Review and Improvement
From: Anthony Fieroni <noreply () phabricator ! kde ! org>
Date: 2018-07-11 19:03:41
Message-ID: a0dc8cae8927587a166beea107b794ef () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
anthonyfieroni added inline comments.
INLINE COMMENTS
> CMakeLists.txt:16
> +
> +#find_package(GIO)
> +find_package(Soup)
Why you comment it when you use it, see below.
> FwupdBackend.cpp:68
> + if (!m_fetching)
> + m_reviews->initialize();
> + populate(QStringLiteral("Releases"));
Indentations should be 4 spaces, if statement goes with { on same line and } even on \
one line body.
> FwupdBackend.cpp:85
> + g_strdelimit (tmp, "/", '_');
> + return g_strdup_printf ("org.fwupd.%s.device", tmp);
> +}
It's memory leak.
> FwupdSourcesBackend.cpp:75-77
> + else if(value.toInt() == Qt::Unchecked)
> + {
> + if((value.toInt() == Qt::Checked) )
?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D14050
To: abhijeet2096, apol, davidedmundson
Cc: anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14050">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14050#inline-73886">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:16</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">#find_package(GIO) </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">find_package(Soup) </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why \
you comment it when you use it, see below.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14050#inline-73887">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">FwupdBackend.cpp:68</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">m_fetching</span><span class="p">)</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">m_reviews</span><span style="color: #aa2211">-></span><span \
class="n">initialize</span><span class="p">();</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">populate</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"Releases"</span><span class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Indentations should be 4 spaces, if statement goes with { on same line and } \
even on one line body.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14050#inline-73888">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">FwupdBackend.cpp:85</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">g_strdelimit</span> <span class="p">(</span><span class="n">tmp</span><span \
class="p">,</span> <span style="color: #766510">"/"</span><span \
class="p">,</span> <span style="color: #766510">'_'</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span \
style="color: #004012">g_strdup_printf</span> <span class="p">(</span><span \
style="color: #766510">"org.fwupd.%s.device"</span><span class="p">,</span> \
<span class="n">tmp</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">It's memory leak.</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14050#inline-73892">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">FwupdSourcesBackend.cpp:75-77</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #aa4000">else</span> <span \
style="color: #aa4000">if</span><span class="p">(</span><span \
class="n">value</span><span class="p">.</span><span class="n">toInt</span><span \
class="p">()</span> <span style="color: #aa2211">==</span> <span \
class="n">Qt</span><span style="color: #aa2211">::</span><span \
class="n">Unchecked</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">if</span><span class="p">((</span><span class="n">value</span><span \
class="p">.</span><span class="n">toInt</span><span class="p">()</span> <span \
style="color: #aa2211">==</span> <span class="n">Qt</span><span style="color: \
#aa2211">::</span><span class="n">Checked</span><span class="p">)</span> <span \
class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14050">https://phabricator.kde.org/D14050</a></div></div><br \
/><div><strong>To: </strong>abhijeet2096, apol, davidedmundson<br /><strong>Cc: \
</strong>anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic