[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13988: Use subseq matching for service runner
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-07-09 13:08:45
Message-ID: 7d78a057bf3b8054d7b1685ebc16ef25 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham added a comment.


  `plasma-workspace` does compile without D13670 <https://phabricator.kde.org/D13670> \
and KRunner //seems// to work, but it gives me a whole lotta console spew:  
    kf5.kservice.services: Parsing "exist Exec and ( (exist Keywords and 'scover' \
~subin Keywords) or (exist GenericName and 'scover' ~subseq GenericName) or (exist \
Name and 'scover' ~subseq Name) or ('scover' ~subseq Exec) or (exist Comment and \
'scover' ~subseq Comment) )" gave: syntax error  
  We should probably bump the KF5 version requirement in `CMakeLists.txt` here to \
require 5.48.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13988

To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13988">View Revision</a></tr></table><br \
/><div><div><p><tt style="background: #ebebeb; font-size: \
13px;">plasma-workspace</tt> does compile without <a \
href="https://phabricator.kde.org/D13670" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D13670</a> and KRunner \
<em>seems</em> to work, but it gives me a whole lotta console spew:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">kf5.kservice.services: Parsing \
&quot;exist Exec and ( (exist Keywords and &#039;scover&#039; ~subin Keywords) or \
(exist GenericName and &#039;scover&#039; ~subseq GenericName) or (exist Name and \
&#039;scover&#039; ~subseq Name) or (&#039;scover&#039; ~subseq Exec) or (exist \
Comment and &#039;scover&#039; ~subseq Comment) )&quot; gave: syntax \
error</pre></div>

<p>We should probably bump the KF5 version requirement in <tt style="background: \
#ebebeb; font-size: 13px;">CMakeLists.txt</tt> here to require \
5.48.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13988">https://phabricator.kde.org/D13988</a></div></div><br \
/><div><strong>To: </strong>michaeleden, rthomas, Plasma: Workspaces, Plasma, \
broulik<br /><strong>Cc: </strong>ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]