[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-07-05 8:16:49
Message-ID: fcafc5333bdd137124f757ad8e09a688 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik updated this revision to Diff 37173.
broulik edited the test plan for this revision.
broulik added a reviewer: davidedmundson.
broulik added a comment.


  - Use `QPixmapCache` to cache on a per-icon basis and avoid duplicating the first 6 \
icons when all are loaded

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13793?vs=36882&id=37173

REVISION DETAIL
  https://phabricator.kde.org/D13793

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">broulik updated this revision to Diff 37173.<br />broulik \
edited the test plan for this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-2q5qwwcw6ipllt3/">(Show \
Details)</a><br />broulik added a reviewer: davidedmundson.<br />broulik added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13793">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Use <tt \
style="background: #ebebeb; font-size: 13px;">QPixmapCache</tt> to cache on a \
per-icon basis and avoid duplicating the first 6 icons when all are loaded</li> \
</ul></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div \
style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px \
0;">...</div>* The animation still works fine, even when icons are missing<span \
style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br /> \
<br /> When loading all pixmaps as the animation starts the 6 already loaded \
aren&#039;t reused but doing so would significantly more complicate this, making it \
unsuitable for a bugfix release</span></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D13793?vs=36882&amp;id=37173">https://phabricator.kde.org/D13793?vs=36882&amp;id=37173</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13793">https://phabricator.kde.org/D13793</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kcms/icons/main.cpp<br /> \
kcms/icons/main.h<br /> kcms/icons/package/contents/ui/main.qml</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, mart, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]