[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13745: Implement support for virtual desktops on Wayland
From: Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date: 2018-07-03 19:12:23
Message-ID: 700d26f76f21c13553211b2bb1b67cfb () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
zzag added inline comments.
INLINE COMMENTS
> taskfilterproxymodel.h:73
> * @see setVirtualDesktop
> * @returns the number of the virtual desktop used in filtering.
> **/
Is it id or number?
> virtualdesktopinfo.cpp:126
> {
> - return KWindowSystem::numberOfDesktops();
> + QVariantList ids;
> +
ids.reserve(KWindowSystem::numberOfDesktops());
> virtualdesktopinfo.cpp:304
> +
> + foreach (const QString &id, virtualDesktops) {
> + ids << id;
Call reserve method. Also, why not range based for loop?
> waylandtasksmodel.cpp:760
> + QByteArray data(mimeData->data(Private::groupMimeType()));
> + if ((unsigned int)data.size() < sizeof(int) + sizeof(quint32)) {
> + return ids;
How about `static_cast<size_t>(data.size())`?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D13745
To: hein, mart, mvourlakos
Cc: zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13745">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13745#inline-73053">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">taskfilterproxymodel.h:73</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: \
#74777d"> * @see setVirtualDesktop</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "><span style="color: #74777d"> * @returns the number of the \
virtual desktop used in filtering.</span> </div><div style="padding: 0 8px; margin: 0 \
4px; "><span style="color: #74777d"> **/</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is \
it id or number?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D13745#inline-73055">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">virtualdesktopinfo.cpp:126</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);"> <span class="bright"></span><span style="color: #aa4000"><span \
class="bright">return</span></span><span class="bright"> </span><span class="n"><span \
class="bright">KWindowSystem</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">numberOfDesktops</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="bright"></span><span class="n"><span \
class="bright">QVariantList</span></span><span class="bright"> </span><span \
class="n"><span class="bright">ids</span></span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">ids.reserve(KWindowSystem::numberOfDesktops());</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13745#inline-73056">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">virtualdesktopinfo.cpp:304</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span class="n">foreach</span> <span class="p">(</span><span \
style="color: #aa4000">const</span> <span class="n">QString</span> <span \
style="color: #aa2211">&</span><span class="n">id</span><span class="p">,</span> \
<span class="n">virtualDesktops</span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">ids</span> <span style="color: \
#aa2211"><<</span> <span class="n">id</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Call reserve method. Also, why not range based for \
loop?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13745#inline-73057">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">waylandtasksmodel.cpp:760</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">QByteArray</span> <span class="n">data</span><span class="p">(</span><span \
class="n">mimeData</span><span style="color: #aa2211">-></span><span \
class="n">data</span><span class="p">(</span><span class="n">Private</span><span \
style="color: #aa2211">::</span><span class="n">groupMimeType</span><span \
class="p">()));</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span \
class="p">((</span><span style="color: #aa4000">unsigned</span> <span style="color: \
#aa4000">int</span><span class="p">)</span><span class="n">data</span><span \
class="p">.</span><span class="n">size</span><span class="p">()</span> <span \
style="color: #aa2211"><</span> <span style="color: #aa4000">sizeof</span><span \
class="p">(</span><span style="color: #aa4000">int</span><span class="p">)</span> \
<span style="color: #aa2211">+</span> <span style="color: #aa4000">sizeof</span><span \
class="p">(</span><span class="n">quint32</span><span class="p">))</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span \
class="n">ids</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">How \
about <tt style="background: #ebebeb; font-size: \
13px;">static_cast<size_t>(data.size())</tt>?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13745">https://phabricator.kde.org/D13745</a></div></div><br \
/><div><strong>To: </strong>hein, mart, mvourlakos<br /><strong>Cc: </strong>zzag, \
ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic