[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13853: Fix setting primary connector if primary output changed
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-07-03 17:17:19
Message-ID: 936baf093951224b333590a3411e96ed () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> screenpool.cpp:108
> }
> Q_ASSERT(m_idForConnector.contains(primary));
> 

Either this is a valid case to be in, and this assert doesn't make sense.

Or we should never be in this case, and the patch doesn't make sense.

I don't fully understand the background of how we end up in this situation to say \
which it is.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13853

To: hoffmannrobert, #plasma, mart, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added inline comments.<br />This revision now requires changes to \
proceed. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13853">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13853#inline-73049">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">screenpool.cpp:108</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Q_ASSERT</span><span \
class="p">(</span><span class="n">m_idForConnector</span><span \
class="p">.</span><span class="n">contains</span><span class="p">(</span><span \
class="n">primary</span><span class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Either this is a valid case to be in, and this assert doesn&#039;t make \
sense.</p>

<p style="padding: 0; margin: 8px;">Or we should never be in this case, and the patch \
doesn&#039;t make sense.</p>

<p style="padding: 0; margin: 8px;">I don&#039;t fully understand the background of \
how we end up in this situation to say which it \
is.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13853">https://phabricator.kde.org/D13853</a></div></div><br \
/><div><strong>To: </strong>hoffmannrobert, Plasma, mart, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, ngraham, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]