[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13870: Correct Folder View sizing and representation switch behavior
From:       Eike Hein <noreply () phabricator ! kde ! org>
Date:       2018-07-03 16:12:41
Message-ID: 20bc407ffeab61b6a87e2889811c7317 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

hein created this revision.
hein added reviewers: mart, broulik, mvourlakos.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  - Resolve inherent layout hint conflicts between full and compact representations \
by setting them seperately. This fixes a recent regression causing tiny popups.  
  BUG:395477
  
  - Correctly respect the panel icon size hint when scaling the compact \
                representation, with the code and behavior now matching the Icon \
                applet.
  - Only expand into the full representation in place on vertical panels. This is not \
a bugfix, and optional. But I think the expansion is useless on horizontal panels, \
and this means fewer users have to care about changing the panel icon size hint if \
they're using a really tall horizontal panel or Latte with parabolic zooming.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13870

AFFECTED FILES
  containments/desktop/package/contents/ui/CompactRepresentation.qml
  containments/desktop/package/contents/ui/main.qml

To: hein, mart, broulik, mvourlakos
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">hein created this revision.<br />hein added reviewers: mart, \
broulik, mvourlakos.<br />Restricted Application added a project: Plasma.<br />hein \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13870">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list"> <li \
class="remarkup-list-item">Resolve inherent layout hint conflicts between full and \
compact representations by setting them seperately. This fixes a recent regression \
causing tiny popups.</li> </ul>

<p>BUG:395477</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Correctly respect the panel icon size hint when \
scaling the compact representation, with the code and behavior now matching the Icon \
applet.</li> <li class="remarkup-list-item">Only expand into the full representation \
in place on vertical panels. This is not a bugfix, and optional. But I think the \
expansion is useless on horizontal panels, and this means fewer users have to care \
about changing the panel icon size hint if they&#039;re using a really tall \
horizontal panel or Latte with parabolic zooming.</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13870">https://phabricator.kde.org/D13870</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/package/contents/ui/CompactRepresentation.qml<br \
/> containments/desktop/package/contents/ui/main.qml</div></div></div><br \
/><div><strong>To: </strong>hein, mart, broulik, mvourlakos<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]