[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13717: Implement Seek() and Seeked()
From:       Adam Mokhtari <noreply () phabricator ! kde ! org>
Date:       2018-06-29 19:29:45
Message-ID: 5d9e69239f76ebf8dae8269da1c7757d () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mokhtari marked 3 inline comments as done.
mokhtari added inline comments.

INLINE COMMENTS

> broulik wrote in content-script.js:177
> Please avoid negating a longer statement, this makes the code hard to understand at a glance:
> 
> if (activePlayer.seekable.length === 0)

Good point. Fixed.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13717

To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, Danial0_0, johnq, \
ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, seebauer, bugzy, \
MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">mokhtari marked 3 inline comments as done.<br />mokhtari added inline \
comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px \
solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13717">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: \
6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; \
margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: \
hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13717#inline-72546">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">content-script.js:177</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">Please avoid negating a longer statement, this \
makes the code hard to understand at a glance:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: 12px; margin: \
0; background: rgba(71, 87, 120, 0.08);">if (activePlayer.seekable.length === \
0)</pre></div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Good point. Fixed.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser \
Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13717">https://phabricator.kde.org/D13717</a></div></div><br \
/><div><strong>To: </strong>mokhtari, broulik<br /><strong>Cc: </strong>nicolasfella, \
plasma-devel, KDE Connect, timothyc, jdvr, yannux, Danial0_0, johnq, ragreen, Pitel, adeen-s, \
SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, seebauer, bugzy, MayeulC, menasshock, \
lesliezhai, ali-mohamed, jensreuterberg, ach, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]