[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13793: [Icons KCM] Cache preview pixmaps
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-06-29 9:51:40
Message-ID: 783c2f3d87b97c84451097ead941d0b5 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  ListView deletes and recreates delegates as you scroll, leading to us recreating \
the icon pixmaps as you scroll up and down with many themes installed

TEST PLAN
  Verified that every icon theme is loaded only once
  Scrolling down initially is still a bit sluggish depending on themes (I should also \
delay loading the animated preview pixmaps..) but once it's loaded it's fast

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13793

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/icons/main.h

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: \
Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel.<br />broulik requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13793">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>ListView deletes and recreates \
delegates as you scroll, leading to us recreating the icon pixmaps as you scroll up \
and down with many themes installed</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Verified that every icon theme is loaded only once<br /> \
Scrolling down initially is still a bit sluggish depending on themes (I should also \
delay loading the animated preview pixmaps..) but once it&#039;s loaded it&#039;s \
fast</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13793">https://phabricator.kde.org/D13793</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kcms/icons/main.cpp<br /> \
kcms/icons/main.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma<br \
/><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]