[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13745: Implement support for virtual desktops on Wayland
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-06-29 13:44:37
Message-ID: d0e06f51cd53df449edd224524b774c0 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mart added inline comments.

INLINE COMMENTS

> waylandtasksmodel.cpp:458
> +        return (window->plasmaVirtualDesktops().isEmpty()
> +        || d->virtualDesktopInfo->numberOfDesktops() == \
> window->plasmaVirtualDesktops().count()); } else if (role == Geometry) {

note that the protocol ensures the list of desktops is empty when is on all virtual \
desktops, even when every desktop has been added by hand

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13745

To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13745">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13745#inline-72587">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">waylandtasksmodel.cpp:458</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, \
175, .7);">        <span style="color: #aa4000">return</span> <span \
class="n">window</span><span style="color: #aa2211">-&gt;<span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">isOnAl</span>lDesktops</span><span class="p">()<span \
class="bright">;</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">return</span> <span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="n">window</span><span style="color: \
#aa2211">-&gt;<span class="bright"></span></span><span class="bright"></span><span \
class="n"><span class="bright">plasmaVirtua</span>lDesktops</span><span \
class="p">()<span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">isEmpty</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa2211">||</span> <span class="n">d</span><span style="color: \
#aa2211">-&gt;</span><span class="n">virtualDesktopInfo</span><span style="color: \
#aa2211">-&gt;</span><span class="n">numberOfDesktops</span><span class="p">()</span> \
<span style="color: #aa2211">==</span> <span class="n">window</span><span \
style="color: #aa2211">-&gt;</span><span class="n">plasmaVirtualDesktops</span><span \
class="p">().</span><span class="n">count</span><span class="p">());</span> \
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span> <span \
style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">role</span> <span style="color: #aa2211">==</span> \
<span class="n">Geometry</span><span class="p">)</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">note that the protocol ensures the list of desktops is empty when is on \
all virtual desktops, even when every desktop has been added by \
hand</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13745">https://phabricator.kde.org/D13745</a></div></div><br \
/><div><strong>To: </strong>hein, mart<br /><strong>Cc: </strong>plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]