[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13785: Use i18np for a plural string
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-06-28 19:11:03
Message-ID: f7110aaa61719693edaf77d1619e0e4e () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham created this revision.
ngraham added a reviewer: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use `i18np()` even though this string will always be plural in English; other \
languages are different, so we should use the correct `i18np()` call.

REPOSITORY
  R134 Discover Software Store

BRANCH
  proper-plural (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13785

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham created this revision.<br />ngraham added a reviewer: \
Discover Software Store.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />ngraham requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13785">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Use <tt style="background: #ebebeb; \
font-size: 13px;">i18np()</tt> even though this string will always be plural in \
English; other languages are different, so we should use the correct <tt \
style="background: #ebebeb; font-size: 13px;">i18np()</tt> call.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br /><div><strong>BRANCH</strong><div><div>proper-plural \
(branched from master)</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13785">https://phabricator.kde.org/D13785</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>discover/qml/ApplicationPage.qml</div></div></div><br \
/><div><strong>To: </strong>ngraham, Discover Software Store<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]