[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13770: Only show available ports in port selection
From:       Nicolas Fella <noreply () phabricator ! kde ! org>
Date:       2018-06-27 20:55:40
Message-ID: a54360018b821105f2567a9e07921441 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

nicolasfella created this revision.
nicolasfella added a reviewer: drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Unavailable ports are marked as unavailable, but can be selected nevertheless, \
which does not make  sense. This removes them from the combobox. If the availability \
is unknown they are left in because they   might be useful.

TEST PLAN
  Works on my card where always excactly one port is available. (Un-)plugging the \
headphone shows the   appropriate port in the Combobox (if I remove the 'visible: \
portbox.count > 1' line).  I can't produce a setup where two ports are available at \
the same time, so switching ports via combobox is   untested.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  portbox

REVISION DETAIL
  https://phabricator.kde.org/D13770

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml

To: nicolasfella, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">nicolasfella created this revision.<br />nicolasfella added a \
reviewer: drosca.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />nicolasfella \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13770">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Unavailable ports are marked as \
unavailable, but can be selected nevertheless, which does not make<br /> sense. This \
removes them from the combobox. If the availability is unknown they are left in \
because they <br /> might be useful.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Works on my card where always excactly one port is available. \
(Un-)plugging the headphone shows the <br /> appropriate port in the Combobox (if I \
remove the &#039;visible: portbox.count &gt; 1&#039; line).<br /> I can&#039;t \
produce a setup where two ports are available at the same time, so switching ports \
via combobox is <br /> untested.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>portbox</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13770">https://phabricator.kde.org/D13770</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/kcm/package/contents/ui/DeviceListItem.qml</div></div></div><br \
/><div><strong>To: </strong>nicolasfella, drosca<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]