[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13760: [Media Frame] Fix history length property
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2018-06-27 14:12:09
Message-ID: b350cc42b0dd8ff2372e6d600036409b () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dfaure added inline comments.

INLINE COMMENTS

> davidedmundson wrote in mediaframe.cpp:336
> This could have just been an else of the branch above

And then one day someone adds a check for contains() before prepend(), for instance, \
and you would need to come back to this structure of the code. So this is more \
flexible.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13760

To: broulik, #plasma, dfaure, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13760">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13760#inline-72326">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">mediaframe.cpp:336</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">This could have just been an else of the branch above</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">And then \
one day someone adds a check for contains() before prepend(), for instance, and you \
would need to come back to this structure of the code. So this is more \
flexible.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13760">https://phabricator.kde.org/D13760</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, dfaure, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]