[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13767: Touchpad KCM Pointer Speed Slider Improvement
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-06-27 19:26:45
Message-ID: 3fd13fa93140ee5f3dc87f9239c8e049 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Almost perfect, just one issue below:

INLINE COMMENTS

> main.qml:239
> if (!enabled) {
> -                    value = 0.1
> +                    value = 0.0
> return

Let's do this in a separate commit where we change it along with the same value in \
the Mouse KCM.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13767

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13767">View \
Revision</a></tr></table><br /><div><div><p>Almost perfect, just one issue \
below:</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13767#inline-72356">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:239</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span style="color: #004012">enabled</span><span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">                    <span style="color: \
#004012">value</span> <span style="color: #aa2211">=</span> <span style="color: \
#601200">0.<span class="bright">1</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span \
style="color: #004012">value</span> <span style="color: #aa2211">=</span> <span \
style="color: #601200">0.<span class="bright">0</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: \
#aa4000">return</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Let&#039;s do this in a separate commit where we change it along with the same \
value in the Mouse KCM.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13767">https://phabricator.kde.org/D13767</a></div></div><br \
/><div><strong>To: </strong>furkantokac, ngraham, romangg, Plasma<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]