[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13679: Fix recent toolbar layout regression
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-06-27 9:50:55
Message-ID: a93769e6901700d6cfe4ae54063835f9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mart added a comment.


  In D13679#283361 <https://phabricator.kde.org/D13679#283361>, @ngraham wrote:
  
  > Aleix implemented a better version of this with \
https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233 \
  
  I'm still not sure about it.
  is it supposed to switch to breadcrumb when the window is narrow? (and buttons as \
fab on the bottom) in kirigami desktop apps are supposed to always have the top \
toolbar, even when they are narrow, that's why it gets navigation buttons, even when \
they are in tablet mode: bottom action buttons are purely for reachability in single \
hand mode on phones.  
  Note that this has nothing to do with plasma mobile, there it would always be in \
breadcrumb+fab mode (you can test its behavior on desktop with export \
QT_QUICK_CONTROLS_MOBILE=1)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13679

To: ngraham, #discover_software_store
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13679">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13679#283361" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D13679#283361</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Aleix implemented a better version of this \
with <a href="https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233</a></p></div>
 </blockquote>

<p>I&#039;m still not sure about it.<br />
is it supposed to switch to breadcrumb when the window is narrow? (and buttons as fab \
on the bottom) in kirigami desktop apps are supposed to always have the top toolbar, \
even when they are narrow, that&#039;s why it gets navigation buttons, even when they \
are in tablet mode: bottom action buttons are purely for reachability in single hand \
mode on phones.</p>

<p>Note that this has nothing to do with plasma mobile, there it would always be in \
breadcrumb+fab mode (you can test its behavior on desktop with export \
QT_QUICK_CONTROLS_MOBILE=1)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13679">https://phabricator.kde.org/D13679</a></div></div><br \
/><div><strong>To: </strong>ngraham, Discover Software Store<br /><strong>Cc: \
</strong>mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]