[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13611: [Fonts KCM] disable "to" label when its companion controls are also disabled
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-06-27 9:40:24
Message-ID: 11c24c4164acd6100c11b700fe64021a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added inline comments.

INLINE COMMENTS

> main.qml:103
> Layout.preferredWidth: formLayout.maxImplicitWidth
> enabled: antiAliasingComboBox.currentIndex == 0
> QtControls.SpinBox {

Also could have been done here, since `enabled` propagates recursively

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13611

To: ngraham, #vdg, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13611">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13611#inline-72279">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:103</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">            <span style="color: \
#aa4000">Layout.preferredWidth:</span> <span style="color: \
#004012">formLayout</span><span class="p">.</span><span style="color: \
#004012">maxImplicitWidth</span> </div><div style="padding: 0 8px; margin: 0 4px; ">  \
<span style="color: #aa4000">enabled:</span> <span style="color: \
#004012">antiAliasingComboBox</span><span class="p">.</span><span style="color: \
#004012">currentIndex</span> <span style="color: #aa2211">==</span> <span \
style="color: #601200">0</span> </div><div style="padding: 0 8px; margin: 0 4px; ">   \
<span style="color: #004012">QtControls</span><span class="p">.</span><span \
style="color: #004012">SpinBox</span> <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Also \
could have been done here, since <tt style="background: #ebebeb; font-size: \
13px;">enabled</tt> propagates recursively</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13611">https://phabricator.kde.org/D13611</a></div></div><br \
/><div><strong>To: </strong>ngraham, VDG, davidedmundson<br /><strong>Cc: \
</strong>broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]