[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13745: Implement support for virtual desktops on Wayland
From: Eike Hein <noreply () phabricator ! kde ! org>
Date: 2018-06-26 21:30:27
Message-ID: 74c425d53b1b1ee03242d8455c07f6b2 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
hein created this revision.
hein added a reviewer: mart.
Restricted Application added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
Includes, among other things:
- A refactoring towards supporting more than one desktop per window, for an \
eventual virtual desktops / activities merge
- A scheme for process-internal window ids on Wayland as DND payload so DND in and \
to the Pager works in the shell
- Implemented various previously missing behavior in WaylandTasksModel such as \
implicit moves of windows to the current desktop on various actions
- Expanded VirtualDesktopInfo API so the Pager can better abstract over windowing \
systems
- Implicit internal sharing of VirtualDesktopInfo since there are many more \
instances now
- Various cleanups
Still missing:
- Fixing the VirtualDesktops data role in the grouping proxy
- The protocol doesn't have desktop creation/destruction yet, so some of the \
related logic is still missing
- Some FIXME TODOs in the code when I was unhappy with the current KWayland API
This code is largely untested and subject to change.
Depends on D12820 <https://phabricator.kde.org/D12820> and relates to T4457 \
<https://phabricator.kde.org/T4457>.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13745
AFFECTED FILES
libtaskmanager/abstracttasksmodel.cpp
libtaskmanager/abstracttasksmodel.h
libtaskmanager/abstracttasksmodeliface.h
libtaskmanager/abstracttasksproxymodeliface.cpp
libtaskmanager/abstracttasksproxymodeliface.h
libtaskmanager/launchertasksmodel.cpp
libtaskmanager/startuptasksmodel.cpp
libtaskmanager/taskfilterproxymodel.cpp
libtaskmanager/taskfilterproxymodel.h
libtaskmanager/taskgroupingproxymodel.cpp
libtaskmanager/taskgroupingproxymodel.h
libtaskmanager/tasksmodel.cpp
libtaskmanager/tasksmodel.h
libtaskmanager/virtualdesktopinfo.cpp
libtaskmanager/virtualdesktopinfo.h
libtaskmanager/waylandtasksmodel.cpp
libtaskmanager/waylandtasksmodel.h
libtaskmanager/windowtasksmodel.cpp
libtaskmanager/windowtasksmodel.h
libtaskmanager/xwindowtasksmodel.cpp
libtaskmanager/xwindowtasksmodel.h
To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">hein created this revision.<br />hein added a reviewer: \
mart.<br />Restricted Application added a project: Plasma.<br />hein requested review \
of this revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13745">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Includes, among other things:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">A refactoring towards supporting more than one desktop \
per window, for an eventual virtual desktops / activities merge</li> <li \
class="remarkup-list-item">A scheme for process-internal window ids on Wayland as DND \
payload so DND in and to the Pager works in the shell</li> <li \
class="remarkup-list-item">Implemented various previously missing behavior in \
WaylandTasksModel such as implicit moves of windows to the current desktop on various \
actions</li> <li class="remarkup-list-item">Expanded VirtualDesktopInfo API so the \
Pager can better abstract over windowing systems</li> <li \
class="remarkup-list-item">Implicit internal sharing of VirtualDesktopInfo since \
there are many more instances now</li> <li class="remarkup-list-item">Various \
cleanups</li> </ul>
<p>Still missing:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Fixing the VirtualDesktops data role in the grouping \
proxy</li> <li class="remarkup-list-item">The protocol doesn't have desktop \
creation/destruction yet, so some of the related logic is still missing</li> <li \
class="remarkup-list-item">Some FIXME TODOs in the code when I was unhappy with the \
current KWayland API</li> </ul>
<p>This code is largely untested and subject to change.</p>
<p>Depends on <a href="https://phabricator.kde.org/D12820" style="background-color: \
#e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12820</a> and relates to <a \
href="https://phabricator.kde.org/T4457" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T4457</a>.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13745">https://phabricator.kde.org/D13745</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>libtaskmanager/abstracttasksmodel.cpp<br /> \
libtaskmanager/abstracttasksmodel.h<br /> libtaskmanager/abstracttasksmodeliface.h<br \
/> libtaskmanager/abstracttasksproxymodeliface.cpp<br />
libtaskmanager/abstracttasksproxymodeliface.h<br />
libtaskmanager/launchertasksmodel.cpp<br />
libtaskmanager/startuptasksmodel.cpp<br />
libtaskmanager/taskfilterproxymodel.cpp<br />
libtaskmanager/taskfilterproxymodel.h<br />
libtaskmanager/taskgroupingproxymodel.cpp<br />
libtaskmanager/taskgroupingproxymodel.h<br />
libtaskmanager/tasksmodel.cpp<br />
libtaskmanager/tasksmodel.h<br />
libtaskmanager/virtualdesktopinfo.cpp<br />
libtaskmanager/virtualdesktopinfo.h<br />
libtaskmanager/waylandtasksmodel.cpp<br />
libtaskmanager/waylandtasksmodel.h<br />
libtaskmanager/windowtasksmodel.cpp<br />
libtaskmanager/windowtasksmodel.h<br />
libtaskmanager/xwindowtasksmodel.cpp<br />
libtaskmanager/xwindowtasksmodel.h</div></div></div><br /><div><strong>To: \
</strong>hein, mart<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic