[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13694: Fix wrong availability of profiles and ports.
From:       Nicolas Fella <noreply () phabricator ! kde ! org>
Date:       2018-06-26 20:44:09
Message-ID: f53197b1c882830b9c59a5a60f0db5f1 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

nicolasfella requested changes to this revision.
nicolasfella added a comment.
This revision now requires changes to proceed.


  Sorry, but this does not solve the issue. Now it only shows the profiles that are \
not available. I'll try to make clear why:  profile->available is either 0 (not \
available) or 1 (available)  case not available/0:  Availability will be Unknown and \
since Unknown != Unavailable it will be shown   case available/1:  Availability will \
be Unavailable and since Unavailable == Unavailable it will not be shown  
  The key issue is that Profile::Available and Port::Available have different values \
and should be treated differently.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13694

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">nicolasfella requested changes to this revision.<br \
/>nicolasfella added a comment.<br />This revision now requires changes to proceed. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13694">View Revision</a></tr></table><br \
/><div><div><p>Sorry, but this does not solve the issue. Now it only shows the \
profiles that are not available. I&#039;ll try to make clear why:<br /> \
profile-&gt;available is either 0 (not available) or 1 (available)<br /> case not \
available/0:  Availability will be Unknown and since Unknown != Unavailable it will \
be shown <br /> case available/1:  Availability will be Unavailable and since \
Unavailable == Unavailable it will not be shown</p>

<p>The key issue is that Profile::Available and Port::Available have different values \
and should be treated differently.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13694">https://phabricator.kde.org/D13694</a></div></div><br \
/><div><strong>To: </strong>akrutzler, nicolasfella, broulik, drosca<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]