[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11198: [libbreezecommon] Add box shadow helper
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2018-06-12 9:53:24
Message-ID: 331c4d4768efc4e2a1a22c740783efa0 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

hpereiradacosta added a comment.


  In D11198#277321 <https://phabricator.kde.org/D11198#277321>, @zzag wrote:
  
  > In D11198#238841 <https://phabricator.kde.org/D11198#238841>, @zzag wrote:
  >
  > > F5783057: box-vs-fft.png <https://phabricator.kde.org/F5783057>
  > >  //on the left hand side: box blur, on the right hand size: fft blur//
  >
  >
  > Also, if you think box blur looks okay, I will switch box shadow helper to box \
blur. (that way, we don't need fftw)  
  
  To be honest, I can't really see strong differences between the two. But then I \
have no objection either against keep the dependence on fftw.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11198">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11198#277321" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11198#277321</a>, <a \
href="https://phabricator.kde.org/p/zzag/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@zzag</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11198#238841" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11198#238841</a>, <a \
href="https://phabricator.kde.org/p/zzag/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@zzag</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p><a \
href="https://phabricator.kde.org/F5783057" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F5783057: box-vs-fft.png</a><br />
 <em>on the left hand side: box blur, on the right hand size: fft blur</em></p></div>
</blockquote>

<p>Also, if you think box blur looks okay, I will switch box shadow helper to box \
blur. (that way, we don&#039;t need fftw)</p></div> </blockquote>

<p>To be honest, I can&#039;t really see strong differences between the two. But then \
I have no objection either against keep the dependence on fftw.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11198">https://phabricator.kde.org/D11198</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: \
</strong>ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]