[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13255: Make dependency on KF5NetworkManagerQt optional
From:       Ivan_Čukić <noreply () phabricator ! kde ! org>
Date:       2018-06-09 20:02:52
Message-ID: 82a5c856b1a98155d2c5c92f71a73c3a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ivan added a comment.


  Very nice, thanks. If you want I can accept this (after the `Q_UNUSED` change) and \
I'll do the UI patch separately.

INLINE COMMENTS

> service.cpp:53
> +    {
> +        (void)enabled;
> +    }

You should use `Q_UNUSED` instead.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D13255

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ivan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13255">View Revision</a></tr></table><br \
/><div><div><p>Very nice, thanks. If you want I can accept this (after the <tt \
style="background: #ebebeb; font-size: 13px;">Q_UNUSED</tt> change) and I&#039;ll do \
the UI patch separately.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13255#inline-70205">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">service.cpp:53</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="p">(</span><span style="color: \
#aa4000">void</span><span class="p">)</span><span class="n">enabled</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
should use <tt style="background: #ebebeb; font-size: 13px;">Q_UNUSED</tt> \
instead.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R845 Plasma Vault</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13255">https://phabricator.kde.org/D13255</a></div></div><br \
/><div><strong>To: </strong>asturmlechner, Plasma, ivan<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]