[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13178: Compress calls to configuration slots upon new connections
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-06-07 10:38:03
Message-ID: fc5e1d83066d9a9bc63f9667d807d919 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
broulik added inline comments.
INLINE COMMENTS
> keyboard_daemon.cpp:163
> }
> - connect(xEventNotifier, &XInputEventNotifier::newPointerDevice, this, \
> &KeyboardDaemon::configureMouse);
> - connect(xEventNotifier, &XInputEventNotifier::newKeyboardDevice, this, \
> &KeyboardDaemon::configureKeyboard); + connect(xEventNotifier, \
> &XInputEventNotifier::newPointerDevice, [this]() {configureMouseTimer.start();}); \
> + connect(xEventNotifier, &XInputEventNotifier::newKeyboardDevice, [this]() \
> {configureKeyboardTimer.start();});
Add `this` as context (third argument) to have it auto-disconnect when `this` is \
destroyed, else you'll crash:
connect(xEventNotifier, &XInputEventNotifier::newPointerDevice, this, [this]() { \
configureMouseTimer.start(); });
Or you could perhaps even connect directly (assuming arguments match)
connect(xEventNotifier, &XInputEventNotifier::newPointerDevice, \
&configureMouseTimer, &QTimer::start);
REVISION DETAIL
https://phabricator.kde.org/D13178
To: jacopods, PHID-PROJ-gqbvozptxawndyihp3hs, hein, broulik, drosca
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13178">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13178#inline-69881">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">keyboard_daemon.cpp:163</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="n">connect</span><span class="p">(</span><span \
class="n">xEventNotifier</span><span class="p">,</span> <span style="color: \
#aa2211">&</span><span class="n">XInputEventNotifier</span><span style="color: \
#aa2211">::</span><span class="n">newPointerDevice</span><span class="p">,</span> \
<span style="color: #aa4000">this<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">&</span></span><span class="bright"></span><span class="n"><span \
class="bright">KeyboardDaemon</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="n">configureMouse</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span \
class="n">connect</span><span class="p">(</span><span \
class="n">xEventNotifier</span><span class="p">,</span> <span style="color: \
#aa2211">&</span><span class="n">XInputEventNotifier</span><span style="color: \
#aa2211">::</span><span class="n">newKeyboardDevice</span><span class="p">,</span> \
<span style="color: #aa4000">this<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">&</span></span><span class="bright"></span><span class="n"><span \
class="bright">KeyboardDaemon</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="n">configureKeyboard</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">connect</span><span class="p">(</span><span \
class="n">xEventNotifier</span><span class="p">,</span> <span style="color: \
#aa2211">&</span><span class="n">XInputEventNotifier</span><span style="color: \
#aa2211">::</span><span class="n">newPointerDevice</span><span class="p">,</span> \
<span class="bright"></span><span class="p"><span class="bright">[</span></span><span \
style="color: #aa4000">this<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">]()</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span><span \
class="n">configureMouse<span class="bright">Timer</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span class="bright">start</span></span><span \
class="bright"></span><span class="p"><span class="bright">();}</span>);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">connect</span><span class="p">(</span><span \
class="n">xEventNotifier</span><span class="p">,</span> <span style="color: \
#aa2211">&</span><span class="n">XInputEventNotifier</span><span style="color: \
#aa2211">::</span><span class="n">newKeyboardDevice</span><span class="p">,</span> \
<span class="bright"></span><span class="p"><span class="bright">[</span></span><span \
style="color: #aa4000">this<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">]()</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span><span \
class="n">configureKeyboard<span class="bright">Timer</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span class="bright">start</span></span><span \
class="bright"></span><span class="p"><span class="bright">();}</span>);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Add <tt style="background: #ebebeb; font-size: 13px;">this</tt> as \
context (third argument) to have it auto-disconnect when <tt style="background: \
#ebebeb; font-size: 13px;">this</tt> is destroyed, else you'll crash:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">connect(xEventNotifier, \
&XInputEventNotifier::newPointerDevice, this, [this]() { \
configureMouseTimer.start(); });</pre></div>
<p style="padding: 0; margin: 8px;">Or you could perhaps even connect directly \
(assuming arguments match)</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">connect(xEventNotifier, \
&XInputEventNotifier::newPointerDevice, &configureMouseTimer, \
&QTimer::start);</pre></div></div></div></div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13178">https://phabricator.kde.org/D13178</a></div></div><br \
/><div><strong>To: </strong>jacopods, Plasma (Plasma 5.13), hein, broulik, drosca<br \
/><strong>Cc: </strong>mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic