[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13202: Circular user avatar for Kickoff
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2018-06-05 22:08:17
Message-ID: 20180605220817.1.AF12CC782722B4E8 () phabricator ! kde ! org
[Download RAW message or body]

apol added inline comments.

INLINE COMMENTS

> Header.qml:104
> +            //but in SDDM that's a bit pointless
> +            fragmentShader: "
> +                            varying highp vec2 qt_TexCoord0;

I tried using fragment shader in discover and it ported poorly on different hardware. \
Maybe OpacityMask or Rectangle + clip works too.

> sharvey wrote in Header.qml:139
> Was `faceIcon.status !== Image.Ready`, which I believe was an old timing test when \
> machines were slower. Doesn't seem necessary on modern hardware.

No need to set it to true, just drop the line.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: apol, davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13202">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13202#inline-69696">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Header.qml:104</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #74777d">//but in SDDM that&#39;s a bit pointless</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">            <span style="color: #aa4000">fragmentShader:</span> <span \
style="color: #766510">&quot;</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span style="color: #766510">                   \
varying highp vec2 qt_TexCoord0;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
tried using fragment shader in discover and it ported poorly on different hardware. \
Maybe OpacityMask or Rectangle + clip works too.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13202#inline-69682">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">sharvey</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">Header.qml:139</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Was <tt style="background: #ebebeb; font-size: 13px;">faceIcon.status !== \
Image.Ready</tt>, which I believe was an old timing test when machines were slower. \
Doesn&#039;t seem necessary on modern hardware.</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No need to set it to \
true, just drop the line.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13202">https://phabricator.kde.org/D13202</a></div></div><br \
/><div><strong>To: </strong>sharvey, ngraham, hein, Plasma<br /><strong>Cc: \
</strong>apol, davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]