[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13202: Circular user avatar for Kickoff
From:       Scott Harvey <noreply () phabricator ! kde ! org>
Date:       2018-06-05 20:13:03
Message-ID: 20180605201303.1.3EE08DDF3A29875F () phabricator ! kde ! org
[Download RAW message or body]

sharvey added a comment.


  Let's try this...

INLINE COMMENTS

> Header.qml:139
> +        source: squareFace
> +        visible: true
> width: units.gridUnit * 3

Was `faceIcon.status !== Image.Ready`, which I believe was an old timing test when \
machines were slower. Doesn't seem necessary on modern hardware.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">sharvey added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13202">View Revision</a></tr></table><br \
/><div><div><p>Let&#039;s try this...</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13202#inline-69682">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Header.qml:139</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        \
<span style="color: #aa4000">source:</span> <span class="bright"></span><span \
style="color: #766510"><span class="bright">&quot;user-identity&quot;</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">        <span style="color: #aa4000">visible:</span> <span \
class="bright"></span><span style="color: #004012"><span \
class="bright">faceIcon</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
style="color: #004012"><span class="bright">status</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">!==</span></span><span \
class="bright"> </span><span style="color: #004012"><span \
class="bright">Image</span></span><span class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">Ready</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">source:</span> <span class="bright"></span><span style="color: \
#004012"><span class="bright">squareFace</span></span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">visible:</span> <span class="bright"></span><span style="color: \
#000a65"><span class="bright">true</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">        <span style="color: #aa4000">width:</span> <span \
style="color: #004012">units</span><span class="p">.</span><span style="color: \
#004012">gridUnit</span> <span style="color: #aa2211">*</span> <span style="color: \
#601200">3</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Was \
<tt style="background: #ebebeb; font-size: 13px;">faceIcon.status !== \
Image.Ready</tt>, which I believe was an old timing test when machines were slower. \
Doesn&#039;t seem necessary on modern hardware.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13202">https://phabricator.kde.org/D13202</a></div></div><br \
/><div><strong>To: </strong>sharvey, ngraham, hein, Plasma<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]