[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13326: Hide settings when run on non-supported platform
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-06-04 6:49:21
Message-ID: 20180604064921.1.B05D37D23C6F7452 () phabricator ! kde ! org
[Download RAW message or body]
broulik created this revision.
broulik added reviewers: Plasma, VDG, davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Chrome syncs installed extensions across computers and will install it also on \
Windows, macOS and other unsupported platforms. The extension doesn't work there and \
showing settings for features that don't exist makes no sense. The "About" tab is \
still fully accessible.
TEST PLAN
Depends on D13325 <https://phabricator.kde.org/D13325>
F5889147: Screenshot_20180604_084757.png <https://phabricator.kde.org/F5889147>
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13326
AFFECTED FILES
extension/_locales/en/messages.json
extension/options.css
extension/options.html
extension/options.js
To: broulik, #plasma, #vdg, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, VDG, davidedmundson, fvogt.<br />Restricted Application added a project: \
Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />broulik \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13326">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Chrome syncs installed extensions \
across computers and will install it also on Windows, macOS and other unsupported \
platforms.<br /> The extension doesn't work there and showing settings for \
features that don't exist makes no sense.<br /> The "About" tab is \
still fully accessible.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Depends on <a href="https://phabricator.kde.org/D13325" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D13325</a><br />
<a href="https://phabricator.kde.org/F5889147" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5889147: \
Screenshot_20180604_084757.png</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser \
Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13326">https://phabricator.kde.org/D13326</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>extension/_locales/en/messages.json<br /> \
extension/options.css<br /> extension/options.html<br />
extension/options.js</div></div></div><br /><div><strong>To: </strong>broulik, \
Plasma, VDG, davidedmundson, fvogt<br /><strong>Cc: </strong>plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic