[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13232: introduce Custom color set
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-06-01 10:00:02
Message-ID: 20180601100002.1.73E54A99B57DD5FA () phabricator ! kde ! org
[Download RAW message or body]
broulik added inline comments.
INLINE COMMENTS
> kirigamiplugin.cpp:172
>
> + //qmlRegisterUncreatableType<Kirigami::ThemeOverride>(uri, 2, 5, \
> "ThemeOverride", "Cannot create objects of type ThemeOverride, use it as an \
> attached poperty"); +
What's this?
> basictheme.cpp:138
> + //TODO: primary, accent and background
> + \
> QMetaObject::invokeMethod(basicThemeDeclarative()->instance(this), \
> "__propagateTextColor", Q_ARG(QVariant, QVariant::fromValue(this->parent())), \
> Q_ARG(QVariant, textColor())); + \
> QMetaObject::invokeMethod(basicThemeDeclarative()->instance(this), \
> "__propagateBackgroundColor", Q_ARG(QVariant, QVariant::fromValue(this->parent())), \
> Q_ARG(QVariant, backgroundColor()));
Probably prints warnings for themes that don't have this?
> platformtheme.cpp:314
> +#define PROPAGATECUSTOMCOLOR(colorName, color)\
> + if (colorSet() == Custom) {\
> + for (PlatformTheme *t : d->m_childThemes) {\
Can this lead to issues with non-deterministic setting of properties? Ie. say \
`Kirigami.Theme.textColor` is evaluated before `Kirigami.Theme.colorSet: \
Kirigami.Theme.Custom`?
> platformtheme.h:79
> */
> - Q_PROPERTY(QColor textColor READ textColor NOTIFY colorsChanged)
> + Q_PROPERTY(QColor textColor READ textColor WRITE setTextColor NOTIFY \
> colorsChanged)
Do they need a `RESET`?
> platformtheme.h:220
> void inheritChanged(bool inherit);
> + void colorOverridesChanged(const QJsonObject &overrides);
>
Where is this used?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D13232
To: mart, #kirigami, broulik
Cc: plasma-devel, apol, davidedmundson, mart, hein
[Attachment #3 (unknown)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13232">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13232#inline-68952">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kirigamiplugin.cpp:172</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #74777d">//qmlRegisterUncreatableType<Kirigami::ThemeOverride>(uri, \
2, 5, "ThemeOverride", "Cannot create objects of type ThemeOverride, \
use it as an attached poperty");</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">What's this?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D13232#inline-68951">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">basictheme.cpp:138</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #74777d">//TODO: primary, accent and background</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span \
class="n">invokeMethod</span><span class="p">(</span><span \
class="n">basicThemeDeclarative</span><span class="p">()</span><span style="color: \
#aa2211">-></span><span class="n">instance</span><span class="p">(</span><span \
style="color: #aa4000">this</span><span class="p">),</span> <span style="color: \
#766510">"__propagateTextColor"</span><span class="p">,</span> <span \
class="n">Q_ARG</span><span class="p">(</span><span class="n">QVariant</span><span \
class="p">,</span> <span class="n">QVariant</span><span style="color: \
#aa2211">::</span><span class="n">fromValue</span><span class="p">(</span><span \
style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span \
class="n">parent</span><span class="p">())),</span> <span class="n">Q_ARG</span><span \
class="p">(</span><span class="n">QVariant</span><span class="p">,</span> <span \
class="n">textColor</span><span class="p">()));</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span \
class="n">invokeMethod</span><span class="p">(</span><span \
class="n">basicThemeDeclarative</span><span class="p">()</span><span style="color: \
#aa2211">-></span><span class="n">instance</span><span class="p">(</span><span \
style="color: #aa4000">this</span><span class="p">),</span> <span style="color: \
#766510">"__propagateBackgroundColor"</span><span class="p">,</span> <span \
class="n">Q_ARG</span><span class="p">(</span><span class="n">QVariant</span><span \
class="p">,</span> <span class="n">QVariant</span><span style="color: \
#aa2211">::</span><span class="n">fromValue</span><span class="p">(</span><span \
style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span \
class="n">parent</span><span class="p">())),</span> <span class="n">Q_ARG</span><span \
class="p">(</span><span class="n">QVariant</span><span class="p">,</span> <span \
class="n">backgroundColor</span><span class="p">()));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Probably prints warnings for themes that don't have \
this?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13232#inline-68949">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">platformtheme.cpp:314</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: \
#304a96">#define PROPAGATECUSTOMCOLOR(colorName, color)\</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96"> if (colorSet() == Custom) {\</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96"> for (PlatformTheme *t : d->m_childThemes) \
{\</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can \
this lead to issues with non-deterministic setting of properties? Ie. say <tt \
style="background: #ebebeb; font-size: 13px;">Kirigami.Theme.textColor</tt> is \
evaluated before <tt style="background: #ebebeb; font-size: \
13px;">Kirigami.Theme.colorSet: Kirigami.Theme.Custom</tt>?</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13232#inline-68950">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">platformtheme.h:79</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span \
class="n">QColor</span> <span class="n">textColor</span> <span class="n">READ</span> \
<span class="n">textColor</span> <span class="n">NOTIFY</span> <span \
class="n">colorsChanged</span><span class="p">)</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">QColor</span> \
<span class="n">textColor</span> <span class="n">READ</span> <span \
class="n">textColor</span> <span class="bright"></span><span class="n"><span \
class="bright">WRITE</span></span><span class="bright"> </span><span class="n"><span \
class="bright">setTextColor</span></span><span class="bright"> </span><span \
class="n">NOTIFY</span> <span class="n">colorsChanged</span><span class="p">)</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Do they need a <tt style="background: #ebebeb; font-size: \
13px;">RESET</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D13232#inline-68953">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">platformtheme.h:220</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">void</span> \
<span style="color: #004012">inheritChanged</span><span class="p">(</span><span \
style="color: #aa4000">bool</span> <span class="n">inherit</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span \
style="color: #004012">colorOverridesChanged</span><span class="p">(</span><span \
style="color: #aa4000">const</span> <span class="n">QJsonObject</span> <span \
style="color: #aa2211">&</span><span class="n">overrides</span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Where is this used?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13232">https://phabricator.kde.org/D13232</a></div></div><br \
/><div><strong>To: </strong>mart, Kirigami, broulik<br /><strong>Cc: \
</strong>plasma-devel, apol, davidedmundson, mart, hein<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic