[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13237: Show action.main more prominently on the ToolBarApplicationHeader
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-05-31 16:34:01
Message-ID: 20180531163401.1.58E25C59C3196C18 () phabricator ! kde ! org
[Download RAW message or body]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PrivateActionToolButton.qml:62
>  
> -    flat: true
> +    palette.button: control.kirigamiAction ? control.kirigamiAction.icon.color : undefined
> +    property bool mainButton: false

note that this can't be used directly, as it depends from Qt 5.10
while if the button is colored by the method in D13232 <https://phabricator.kde.org/D13232> this shouldn't happen
so this shouldn't be pushed until can be done without breaking deps

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

[Attachment #3 (unknown)]

<table><tr><td style="">mart requested changes to this revision.<br />mart added inline \
comments.<br />This revision now requires changes to proceed. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13237">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: \
#F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13237#inline-68865">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">PrivateActionToolButton.qml:62</span></div> <div style="font: \
11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: \
#aa4000"><span class="bright">flat:</span></span><span class="bright"> </span><span \
style="color: #000a65"><span class="bright">true</span></span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">palette.button:</span></span><span class="bright"> \
</span><span style="color: #004012"><span class="bright">control</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span style="color: #004012"><span \
class="bright">kirigamiAction</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: \
#aa4000"><span class="bright">control.kirigamiAction.icon.color :</span></span><span \
class="bright"> </span><span style="color: #000a65"><span \
class="bright">undefined</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span style="color: #004012">property</span> <span \
style="color: #004012">bool</span> <span style="color: #aa4000">mainButton:</span> <span \
style="color: #000a65">false</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">note that this \
can&#039;t be used directly, as it depends from Qt 5.10<br /> while if the button is colored by \
the method in <a href="https://phabricator.kde.org/D13232" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13232</a> this shouldn&#039;t happen<br />
so this shouldn&#039;t be pushed until can be done without breaking \
deps</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 \
Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13237">https://phabricator.kde.org/D13237</a></div></div><br \
/><div><strong>To: </strong>apol, Kirigami, mart, ngraham<br /><strong>Cc: </strong>ngraham, \
plasma-devel, apol, davidedmundson, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]