[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13237: Show action.main more prominently on the ToolBarApplicationHeader
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-05-31 14:03:03
Message-ID: 20180531140303.1.387A281AF116B454 () phabricator ! kde ! org
[Download RAW message or body]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Love it! Two issues that I can see:
  
  - In this example, the text really needs to be white; it doesn't show up well \
against the dark green background. If the color is programmatically determined, we \
may need some fancy logic to choose the button's text color to ensure that it's \
                visible enough. For that matter, the icon doesn't show up very well \
                either...
  - The button has no right padding, and touches the window edge ( A Discover issue?)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13237">View \
Revision</a></tr></table><br /><div><div><p>Love it! Two issues that I can see:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">In this example, the text really needs to be white; it \
doesn&#039;t show up well against the dark green background. If the color is \
programmatically determined, we may need some fancy logic to choose the button&#039;s \
text color to ensure that it&#039;s visible enough. For that matter, the icon \
doesn&#039;t show up very well either...</li> <li class="remarkup-list-item">The \
button has no right padding, and touches the window edge ( A Discover issue?)</li> \
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 \
Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13237">https://phabricator.kde.org/D13237</a></div></div><br \
/><div><strong>To: </strong>apol, Kirigami, mart, ngraham<br /><strong>Cc: \
</strong>ngraham, plasma-devel, apol, davidedmundson, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]