[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13194: Use the new drag handle in the Language KCM
From:       Eike Hein <noreply () phabricator ! kde ! org>
Date:       2018-05-30 18:00:31
Message-ID: 20180530180031.1.F6F5E89805D6DFEA () phabricator ! kde ! org
[Download RAW message or body]

hein added a comment.


  This is now ready for review.
  
  With the use of DelegateRecycler, I get many ReferenceErrors from particular the \
sheet list delegate during scroll:  
    kcmshell5(8088)/default unknown: \
file:///home/eike/devel/install/share/kpackage/kcms/kcm_translations/contents/ui/main.qml:41: \
TypeError: Cannot read property 'display' of undefined  kcmshell5(8088)/default \
unknown: file:///home/eike/devel/install/share/kpackage/kcms/kcm_translations/contents/ui/main.qml:37: \
TypeError: Cannot read property 'LanguageCode' of undefined  
  I suspect this is some sort of race condition. @mart needs to have a look. The code \
in the diff itself should be unrelated to this I hope.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13194

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hein added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13194">View Revision</a></tr></table><br \
/><div><div><p>This is now ready for review.</p>

<p>With the use of DelegateRecycler, I get many ReferenceErrors from particular the \
sheet list delegate during scroll:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">kcmshell5(8088)/default \
unknown: file:///home/eike/devel/install/share/kpackage/kcms/kcm_translations/contents/ui/main.qml:41: \
TypeError: Cannot read property &#039;display&#039; of undefined \
kcmshell5(8088)/default unknown: \
file:///home/eike/devel/install/share/kpackage/kcms/kcm_translations/contents/ui/main.qml:37: \
TypeError: Cannot read property &#039;LanguageCode&#039; of undefined</pre></div>

<p>I suspect this is some sort of race condition. <a \
href="https://phabricator.kde.org/p/mart/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@mart</a> needs to have a look. The code in the diff \
itself should be unrelated to this I hope.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13194">https://phabricator.kde.org/D13194</a></div></div><br \
/><div><strong>To: </strong>hein, mart, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]