[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13194: Use the new drag handle in the Language KCM
From:       Eike Hein <noreply () phabricator ! kde ! org>
Date:       2018-05-30 17:57:07
Message-ID: 20180530175707.1.FDC03B050A027652 () phabricator ! kde ! org
[Download RAW message or body]

hein updated this revision to Diff 35207.
hein edited the summary of this revision.
hein added a reviewer: davidedmundson.
hein added a comment.


  - Rewrite model backend to make list drag handle happy.
  - Use QCollator for available languages.
  - Code cleanup.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13194?vs=35110&id=35207

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13194

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hein updated this revision to Diff 35207.<br />hein edited \
the summary of this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-xsb5grawsudtbsq/">(Show \
Details)</a><br />hein added a reviewer: davidedmundson.<br />hein added a comment. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13194">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Rewrite model \
backend to make list drag handle happy.</li> <li class="remarkup-list-item">Use \
QCollator for available languages.</li> <li class="remarkup-list-item">Code \
cleanup.</li> </ul></div></div><br /><div><strong>CHANGES TO REVISION \
SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span \
style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, \
.7);">WIP</span><span style="padding: 0 2px; color: #333333; background: rgba(151, \
234, 151, .6);">This makes the list items draggable.<br /> <br />
To do this, the backend model was split up into three models so<br />
the move() method could actually move a row as the new drag handle<br />
expects. This also makes move and remove actions a little bit<br />
faster since there&#039;s no proxy abstractions involved. The use of<br />
Plasma.SortFilterModel with JS callbacks for filtering has been<br />
dropped from the QML code.<br />
<br />
The list of available languages is now guaranteed to be sorted in<br />
a locale-aware manner and case-insensitively, using QCollator.<br />
This likely works better than whatever PSFM was doing with the<br />
Qt::DisplayRole sort role before.<br />
<br />
Also drops a stray unused KConfigGroup member from<br />
TranslationsModel</span>.</div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D13194?vs=35110&amp;id=35207">https://phabricator.kde.org/D13194?vs=35110&amp;id=35207</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13194">https://phabricator.kde.org/D13194</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcms/translations/package/contents/ui/main.qml<br /> \
kcms/translations/translations.cpp<br /> kcms/translations/translations.h<br />
kcms/translations/translationsmodel.cpp<br />
kcms/translations/translationsmodel.h</div></div></div><br /><div><strong>To: \
</strong>hein, mart, davidedmundson<br /><strong>Cc: </strong>plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]