[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12982: Make the new KCMs with QtQuick translatable
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-05-30 14:08:49
Message-ID: 20180530140849.1.1028290A281CCDA4 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  > is this something that needs to be fixed in kdeclarative
  
  I don't think so.
  This patch seems fine, it's no different to our current state of how applet \
translations work following a fixed pot schema.  
  >   would a patch to fix this (define the translation domain in the same way as the \
other libraries, not related to component name) accepted?  
  Accepted, sure. But the QtQuick loading is quite separate from the library here, so \
I'm not sure it's easy.  
  If we want to have QtQuick only KCMs (something I think probably isn't useful, but \
I know Marco wants) we would still need to load pots based on plugin metadata names \
like it is currently.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano, davidedmundson
Cc: davidedmundson, mart, hein, aacid, ltoscano, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12982">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>is this something that needs to be fixed in \
kdeclarative</p></blockquote>

<p>I don&#039;t think so.<br />
This patch seems fine, it&#039;s no different to our current state of how applet \
translations work following a fixed pot schema.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div \
class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">would a patch to fix this \
(define the translation domain in the same way as the other libraries, not related to \
component name) accepted?</pre></div></blockquote>

<p>Accepted, sure. But the QtQuick loading is quite separate from the library here, \
so I&#039;m not sure it&#039;s easy.</p>

<p>If we want to have QtQuick only KCMs (something I think probably isn&#039;t \
useful, but I know Marco wants) we would still need to load pots based on plugin \
metadata names like it is currently.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12982">https://phabricator.kde.org/D12982</a></div></div><br \
/><div><strong>To: </strong>yurchor, Plasma, kde-i18n-doc, ltoscano, \
davidedmundson<br /><strong>Cc: </strong>davidedmundson, mart, hein, aacid, ltoscano, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]