[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13192: Implement a triangle filter for mouse events on the Kickoff tabbar
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-05-30 13:14:58
Message-ID: 20180530131458.1.A9724FB904D45802 () phabricator ! kde ! org
[Download RAW message or body]
broulik added a comment.
Minor code nitpicks.
Tab instant switch makes it feel a lot more responsive but I occasionally managed \
to accidentally activate the "Apps" tab when opening and moving, not sure how much \
that could happen in "normal use", though. +1 anyway
INLINE COMMENTS
> FullRepresentation.qml:402
> +
> + property var oldPos: null
> +
`property point` or is that on purpose so you can set it to `null` instead to avoid \
ambiguity with e.g. `-1,-1`?
> FullRepresentation.qml:434
> +
> + var dx = (mouse.x - oldPos.x);
> + var dy = (mouse.y - oldPos.y);
Coding style, one space before `=`
> FullRepresentation.qml:493
> + return;
> + } else {
> + clickTimer.pendingButton = button;
No `else` since you `return` in the `if` branch
if (...) {
...
return;
}
...
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13192
To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol
[Attachment #3 (unknown)]
<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13192">View Revision</a></tr></table><br \
/><div><div><p>Minor code nitpicks.</p>
<p>Tab instant switch makes it feel a lot more responsive but I occasionally managed \
to accidentally activate the "Apps" tab when opening and moving, not sure \
how much that could happen in "normal use", though. +1 \
anyway</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13192#inline-68636">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">FullRepresentation.qml:402</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#004012">property</span> <span style="color: #aa4000">var</span> <span style="color: \
#aa4000">oldPos:</span> <span style="color: #000a65">null</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt \
style="background: #ebebeb; font-size: 13px;">property point</tt> or is that on \
purpose so you can set it to <tt style="background: #ebebeb; font-size: \
13px;">null</tt> instead to avoid ambiguity with e.g. <tt style="background: #ebebeb; \
font-size: 13px;">-1,-1</tt>?</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13192#inline-68637">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">FullRepresentation.qml:434</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #aa4000">var</span> <span style="color: \
#004012">dx</span> <span style="color: #aa2211">=</span> <span \
class="p">(</span><span style="color: #004012">mouse</span><span \
class="p">.</span><span style="color: #004012">x</span> <span style="color: \
#aa2211">-</span> <span style="color: #004012">oldPos</span><span \
class="p">.</span><span style="color: #004012">x</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">var</span> <span style="color: \
#004012">dy</span> <span style="color: #aa2211">=</span> <span \
class="p">(</span><span style="color: #004012">mouse</span><span \
class="p">.</span><span style="color: #004012">y</span> <span style="color: \
#aa2211">-</span> <span style="color: #004012">oldPos</span><span \
class="p">.</span><span style="color: #004012">y</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Coding style, one space before <tt style="background: #ebebeb; \
font-size: 13px;">=</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D13192#inline-68638">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">FullRepresentation.qml:493</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #aa4000">return</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="p">}</span> <span \
style="color: #aa4000">else</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #004012">clickTimer</span><span class="p">.</span><span \
style="color: #004012">pendingButton</span> <span style="color: #aa2211">=</span> \
<span style="color: #004012">button</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No \
<tt style="background: #ebebeb; font-size: 13px;">else</tt> since you <tt \
style="background: #ebebeb; font-size: 13px;">return</tt> in the <tt \
style="background: #ebebeb; font-size: 13px;">if</tt> branch</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (...) {
...
return;
}
...</pre></div></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13192">https://phabricator.kde.org/D13192</a></div></div><br \
/><div><strong>To: </strong>hein, ngraham, davidedmundson, rkflx, cfeck<br \
/><strong>Cc: </strong>broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic