[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13202: Circular user avatar for Kickoff
From:       Scott Harvey <noreply () phabricator ! kde ! org>
Date:       2018-05-30 9:20:16
Message-ID: 20180530092016.1.EDA50C88E8E8C65F () phabricator ! kde ! org
[Download RAW message or body]

sharvey added a comment.


  In D13202#270585 <https://phabricator.kde.org/D13202#270585>, @ngraham wrote:
  
  > Looks great now! Quite pleasing to the eye.
  >
  > I've got a few blockers though:
  >
  > - When I change the icon in the user-manager KCM and re-open Kickoff, the new \
icon isn't displayed; instead I just see a blank circle with no image in it until I \
quit and restart plasmashell.  
  
  That's odd. It shows us something *is* updating, just not correctly or completely. \
What's strange is that it seems to be removing the old avatar but not yet updating \
with the new one.

INLINE COMMENTS

> ngraham wrote in Header.qml:19
> This version bump makes Kickoff require Qt 5.11. I wasn't are that we were going to \
> make Plasma 5.14 depend on Qt 5.11. At the minimum, it makes this hard to test \
> without compiling your own Qt. Is there anything we're actually depending on with \
> this patch that was added with 2.11, or can we reduce the minimum version? I \
> manually changed it to 2.10 and didn't notice any issues...

No, that version bump was likely from an earlier attempt using a different technique  \
I'll get it dialed back to the correct minimum and will repost.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">sharvey added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13202">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13202#270585" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13202#270585</a>, <a \
href="https://phabricator.kde.org/p/ngraham/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Looks great now! Quite pleasing to the \
eye.</p>

<p>I&#039;ve got a few blockers though:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">When I change the icon in the user-manager KCM and \
re-open Kickoff, the new icon isn&#039;t displayed; instead I just see a blank circle \
with no image in it until I quit and restart plasmashell.</li> </ul></div>
</blockquote>

<p>That's odd. It shows us something *is* updating, just not correctly or completely. \
What's strange is that it seems to be removing the old avatar but not yet updating \
with the new one.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13202#inline-68558">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">ngraham</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">Header.qml:19</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">This version bump makes Kickoff require Qt 5.11. I wasn&#039;t are that we were \
going to make Plasma 5.14 depend on Qt 5.11. At the minimum, it makes this hard to \
test without compiling your own Qt. Is there anything we&#039;re actually depending \
on with this patch that was added with 2.11, or can we reduce the minimum version? I \
manually changed it to 2.10 and didn&#039;t notice any issues...</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No, that \
version bump was likely from an earlier attempt using a different technique  I'll get \
it dialed back to the correct minimum and will \
repost.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13202">https://phabricator.kde.org/D13202</a></div></div><br \
/><div><strong>To: </strong>sharvey, ngraham, hein, Plasma<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]