[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10297: Add new "Tools" button above System Monitor's process list
From: gregormi <noreply () phabricator ! kde ! org>
Date: 2018-05-30 8:37:32
Message-ID: 20180530083732.1.4691EC3022E71C37 () phabricator ! kde ! org
[Download RAW message or body]
gregormi updated this revision to Diff 35172.
gregormi added a comment.
> The text should use title case: "Kill a Window"
DONE
> The parentheses look a bit ugly, in normal menus the shortcuts are \
simply aligned to the right (not sure how that's done, though).
DONE: align the shortcut strings to the right using \t
> At least for Run Command the shortcut should be shown (just like in the \
desktop context menu)
DONE: Add shortcut to 'Run Command' item
> The shortcut does not get localized. (In the global shortcuts KCM, it \
is localized correctly for me.)
DONE: using QKeySequence::NativeText; tested with "export LANGUAGE=de_DE"
Remove seemingly useless 'class KGlobalAccel'
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10297?vs=34204&id=35172
BRANCH
arcpatch-D10297_2
REVISION DETAIL
https://phabricator.kde.org/D10297
AFFECTED FILES
CMakeLists.txt
processui/CMakeLists.txt
processui/ProcessWidgetUI.ui
processui/ksysguardprocesslist.cpp
To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
mart
[Attachment #3 (unknown)]
<table><tr><td style="">gregormi updated this revision to Diff 35172.<br \
/>gregormi added a comment. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px \
solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10297">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: \
3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px \
0; padding: 4px 12px; background-color: #f8f9fc;"><p>The text should use \
title case: "Kill a Window"</p></blockquote>
<p>DONE</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>The parentheses look a bit ugly, in normal \
menus the shortcuts are simply aligned to the right (not sure how \
that's done, though).</p></blockquote>
<p>DONE: align the shortcut strings to the right using \t</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>At least for Run Command the shortcut should \
be shown (just like in the desktop context menu)</p></blockquote>
<p>DONE: Add shortcut to 'Run Command' item</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>The shortcut does not get localized. (In the \
global shortcuts KCM, it is localized correctly for me.)</p></blockquote>
<p>DONE: using QKeySequence::NativeText; tested with "export \
LANGUAGE=de_DE"</p>
<p>Remove seemingly useless 'class \
KGlobalAccel'</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R111 KSysguard \
Library</div></div></div><br /><div><strong>CHANGES SINCE LAST \
UPDATE</strong><div><a \
href="https://phabricator.kde.org/D10297?vs=34204&id=35172">https://phabricator.kde.org/D10297?vs=34204&id=35172</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>arcpatch-D10297_2</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10297">https://phabricator.kde.org/D10297</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
processui/CMakeLists.txt<br /> processui/ProcessWidgetUI.ui<br />
processui/ksysguardprocesslist.cpp</div></div></div><br /><div><strong>To: \
</strong>gregormi, Plasma, colomar, kossebau, broulik, mart, hein<br \
/><strong>Cc: </strong>apol, anthonyfieroni, andreaska, rkflx, ngraham, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic