[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D7087: Add "Copy Info" button to the About System KCM
From: gregormi <noreply () phabricator ! kde ! org>
Date: 2018-05-30 7:12:33
Message-ID: 20180530071233.1.A205A36407337349 () phabricator ! kde ! org
[Download RAW message or body]
gregormi marked an inline comment as done.
gregormi added inline comments.
INLINE COMMENTS
> rkflx wrote in Module.ui:333-338
> Do you need this? Pressing the Reset button for that property in Qt Designer \
> removes this for me.
If I remove that part, the button gets wider; I would prefer to keep it as small as \
possible.
> rkflx wrote in Module.ui:349-351
> For me the shortcut actually works, but ideally this should use the standard \
> shortcut for copying, which the user might have set to something different than \
> [Ctrl] + [C].
> You could try to look at how it works in Spectacle. I suspect you'd need to add the \
> appropriate action or standard shortcut for that, e.g. `KStandardAction::Copy` or \
> `QKeySequence::Copy`, instead of setting shortcut and icon manually.
The KStandardAction method seems only easily applicable with QToolButtons but not \
with QPushButton. Furthermore, I got the "ambiguous key binding" when I tried it. I \
now settled for QKeySequence::Copy which does not work for me but at least results in \
no error message.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7087
To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">gregormi marked an inline comment as done.<br />gregormi \
added inline comments. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-67938">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">Module.ui:333-338</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Do you need \
this? Pressing the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey \
phui-tag-shade "><span class="phui-tag-core ">Reset</span></span></span> button for \
that property in Qt Designer removes this for me.</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If I remove that part, \
the button gets wider; I would prefer to keep it as small as \
possible.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-67940">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">Module.ui:349-351</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">For me the shortcut actually works, but ideally this should use the standard \
shortcut for copying, which the user might have set to something different than <kbd \
style="display: inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: \
normal; font-size: 0.8rem; text-align: center; text-decoration: none; line-height: \
0.6rem; border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); \
user-select: none; background: #f7f7f7; border: 1px solid #C7CCD9;">Ctrl</kbd><span \
class="kbd-join" style="padding: 0 4px; color: #92969D;">+</span><kbd style="display: \
inline-block; min-width: 1em; padding: 4px 5px 5px; font-weight: normal; font-size: \
0.8rem; text-align: center; text-decoration: none; line-height: 0.6rem; \
border-radius: 3px; box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08); user-select: \
none; background: #f7f7f7; border: 1px solid #C7CCD9;">C</kbd>.</p>
<p style="padding: 0; margin: 8px;">You could try to look at how it works in \
Spectacle. I suspect you'd need to add the appropriate action or standard \
shortcut for that, e.g. <tt style="background: #ebebeb; font-size: \
13px;">KStandardAction::Copy</tt> or <tt style="background: #ebebeb; font-size: \
13px;">QKeySequence::Copy</tt>, instead of setting shortcut and icon \
manually.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">The KStandardAction method seems only easily \
applicable with QToolButtons but not with QPushButton. Furthermore, I got the \
"ambiguous key binding" when I tried it. I now settled for \
QKeySequence::Copy which does not work for me but at least results in no error \
message.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic