[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13183: Use Control.palette
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-05-29 13:42:39
Message-ID: 20180529134239.1.F7E35E952C0DF2D1 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In D13183#270171 <https://phabricator.kde.org/D13183#270171>, @apol wrote:
  
  > In D13183#270156 <https://phabricator.kde.org/D13183#270156>, @mart wrote:
  >
  > > to not break all custom kirigami color set, i think by default all controls in \
the desktop style should be binded to Kirigami.Theme.palette  > >  or the colorset, \
complementary areas gets broken  >
  >
  > Do you want patches like this on every component?
  
  
  yeah, i think it would be nice

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13183

To: apol, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13183">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13183#270171" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13183#270171</a>, <a \
href="https://phabricator.kde.org/p/apol/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@apol</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13183#270156" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13183#270156</a>, <a \
href="https://phabricator.kde.org/p/mart/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@mart</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>to not break all custom kirigami color set, \
i think by default all controls in the desktop style should be binded to \
Kirigami.Theme.palette<br />  or the colorset, complementary areas gets \
broken</p></div> </blockquote>

<p>Do you want patches like this on every component?</p></div>
</blockquote>

<p>yeah, i think it would be nice</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13183">https://phabricator.kde.org/D13183</a></div></div><br \
/><div><strong>To: </strong>apol, Kirigami, mart<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]