[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13183: Use Control.palette
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-05-29 12:55:24
Message-ID: 20180529125524.1.1C171E5F8302C419 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> apol wrote in kquickstyleitem.cpp:716
> In which case will it be a wrong palette? We are reading a Control property, it's \
> not really optional.

m_control comes from any qquickitem, so it's not a given that will be a qqc2 control \
instance

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13183

To: apol, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13183">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13183#inline-68436">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">kquickstyleitem.cpp:716</span></div> <div style="margin: \
8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">In which \
case will it be a wrong palette? We are reading a Control property, it&#039;s not \
really optional.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">m_control comes from any qquickitem, so it&#039;s \
not a given that will be a qqc2 control instance</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13183">https://phabricator.kde.org/D13183</a></div></div><br \
/><div><strong>To: </strong>apol, Kirigami, mart<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]