[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13192: Implement a triangle filter for mouse events on the Kickoff tabbar
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-05-29 11:58:23
Message-ID: 20180529115823.1.5C826A0BA336457D () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:438
> +            var dy  = (mouse.y - oldPos.y);
> +            var manhattanLength = Math.sqrt(dx * dx + dy * dy);
> +

that's normal length.

Manhattan would be dx+dy

As in the distance to walk to another place in the city using only roads in a block \
shaped city such as Manhattan.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13192">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13192#inline-68446">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">FullRepresentation.qml:438</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">            <span style="color: #aa4000">var</span> <span style="color: \
#004012">dy</span>  <span style="color: #aa2211">=</span> <span \
class="p">(</span><span style="color: #004012">mouse</span><span \
class="p">.</span><span style="color: #004012">y</span> <span style="color: \
#aa2211">-</span> <span style="color: #004012">oldPos</span><span \
class="p">.</span><span style="color: #004012">y</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">            <span style="color: #aa4000">var</span> <span style="color: \
#004012">manhattanLength</span> <span style="color: #aa2211">=</span> <span \
style="color: #304a96">Math</span><span class="p">.</span><span style="color: \
#004012">sqrt</span><span class="p">(</span><span style="color: #004012">dx</span> \
<span style="color: #aa2211">*</span> <span style="color: #004012">dx</span> <span \
style="color: #aa2211">+</span> <span style="color: #004012">dy</span> <span \
style="color: #aa2211">*</span> <span style="color: #004012">dy</span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">that&#039;s normal length.</p>

<p style="padding: 0; margin: 8px;">Manhattan would be dx+dy</p>

<p style="padding: 0; margin: 8px;">As in the distance to walk to another place in \
the city using only roads in a block shaped city such as \
Manhattan.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13192">https://phabricator.kde.org/D13192</a></div></div><br \
/><div><strong>To: </strong>hein, ngraham, davidedmundson, rkflx, cfeck<br \
/><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]