[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13183: Use Control.palette
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-05-29 10:37:18
Message-ID: 20180529103718.1.5832E09D85CD77E5 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> kquickstyleitem.cpp:716
> +    if (m_control) {
> +        m_styleoption->palette = m_control->property("palette").value<QPalette>();
> +    } else {

it should check if that proeprty is valid and if managed to get an intelligible \
qpalette out of it

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13183

To: apol, #kirigami, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13183">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13183#inline-68434">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kquickstyleitem.cpp:716</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">m_control</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="n">m_styleoption</span><span style="color: \
#aa2211">-&gt;</span><span class="n">palette</span> <span style="color: \
#aa2211">=</span> <span class="n">m_control</span><span style="color: \
#aa2211">-&gt;</span><span class="n">property</span><span class="p">(</span><span \
style="color: #766510">&quot;palette&quot;</span><span class="p">).</span><span \
class="n">value</span><span style="color: #aa2211">&lt;</span><span \
class="n">QPalette</span><span style="color: #aa2211">&gt;</span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: \
#aa4000">else</span> <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it \
should check if that proeprty is valid and if managed to get an intelligible qpalette \
out of it</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop \
Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13183">https://phabricator.kde.org/D13183</a></div></div><br \
/><div><strong>To: </strong>apol, Kirigami, mart<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]