[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13148: Allow Kirigami build without KWin tablet mode dependency
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-05-29 10:03:13
Message-ID: 20180529100313.1.2AE794EF35866C41 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  almost there :)
  since there is also a qmake mode to build for embedded, where dbus should be \
disabled as well, I would prefer to flip the logic.  so, have a KIRIGAMI_ENABLE_DBUS \
which is undefined by default (so nothing to do in the .pri file)  but having it \
defined by default in the main cmake file, so would become  
    NOT(APPLE) AND NOT(DISABLE_DBUS))
  
  ​    find_package(Qt5DBus)
  	​    add_definitions(-DKIRIGAMI_ENABLE_DBUS)
  	​endif()

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13148

To: murillobernardes, mart, davidedmundson
Cc: davidedmundson, plasma-devel, apol, mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13148">View Revision</a></tr></table><br \
/><div><div><p>almost there :)<br /> since there is also a qmake mode to build for \
embedded, where dbus should be disabled as well, I would prefer to flip the logic.<br \
/> so, have a KIRIGAMI_ENABLE_DBUS which is undefined by default (so nothing to do in \
the .pri file)<br /> but having it defined by default in the main cmake file, so \
would become</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">NOT(APPLE) AND \
NOT(DISABLE_DBUS))</pre></div>

<p>​    find_package(Qt5DBus)<br />
	​    add_definitions(-DKIRIGAMI_ENABLE_DBUS)<br />
	​endif()</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 \
Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13148">https://phabricator.kde.org/D13148</a></div></div><br \
/><div><strong>To: </strong>murillobernardes, mart, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]