[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13095: Scren brightness follow a quatratic progression
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-05-28 21:48:31
Message-ID: 20180528214831.1.A3326165FBDC600B () phabricator ! kde ! org
[Download RAW message or body]

zzag added inline comments.

INLINE COMMENTS

> powerdevilbrightnesslogic.cpp:135
> +        return value * 100.0 / m_valueMax;
> +    } else {
> +        return valueToStep(value) * 100.0 / m_steps;

Coding style nitpick: don't use "else" after a return statement. Same down below.

Kdelibs/Frameworks coding style doesn't say anything about early returns so here are \
links to other coding styles

- https://releases.llvm.org/2.7/docs/CodingStandards.html#hl_else_after_return
- https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#General_C.2FC.2B.2B_Practices \
                (the first item)
- https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md (see \
Code Formatting section)

- https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel, #plasma, broulik, ngraham
Cc: zzag, ngraham, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13095">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13095#inline-68359">View Inline</a><span \
style="color: #4b4d51; font-weight: \
bold;">powerdevilbrightnesslogic.cpp:135</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">        <span style="color: #aa4000">return</span> <span \
class="n">value</span> <span style="color: #aa2211">*</span> <span style="color: \
#601200">100.0</span> <span style="color: #aa2211">/</span> <span \
class="n">m_valueMax</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> \
<span style="color: #aa4000">else</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #aa4000">return</span> <span class="n">valueToStep</span><span \
class="p">(</span><span class="n">value</span><span class="p">)</span> <span \
style="color: #aa2211">*</span> <span style="color: #601200">100.0</span> <span \
style="color: #aa2211">/</span> <span class="n">m_steps</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Coding style nitpick: don&#039;t use &quot;else&quot; after a return statement. \
Same down below.</p>

<p style="padding: 0; margin: 8px;">Kdelibs/Frameworks coding style doesn&#039;t say \
anything about early returns so here are links to other coding styles</p>

<ul class="remarkup-list">
<li class="remarkup-list-item"><a \
href="https://releases.llvm.org/2.7/docs/CodingStandards.html#hl_else_after_return" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://releases.llvm.org/2.7/docs/CodingStandards.html#hl_else_after_return</a></li>
 <li class="remarkup-list-item"><a \
href="https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#General_C.2FC.2B.2B_Practices" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#General_C.2FC.2B.2B_Practices</a> \
(the first item)</li> <li class="remarkup-list-item"><a \
href="https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md</a> \
(see Code Formatting section)</li> </ul>

<ul class="remarkup-list">
<li class="remarkup-list-item"><a \
href="https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html</a></li>
 </ul></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13095">https://phabricator.kde.org/D13095</a></div></div><br \
/><div><strong>To: </strong>thsurrel, Plasma, broulik, ngraham<br /><strong>Cc: \
</strong>zzag, ngraham, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]