[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13178: Compress calls to configuration slots upon new connections
From:       Jacopo De Simoi <noreply () phabricator ! kde ! org>
Date:       2018-05-28 20:42:54
Message-ID: 20180528204254.1.20B6374B44CBE347 () phabricator ! kde ! org
[Download RAW message or body]

jacopods added a comment.


  Short story: It just feels more right to me to compress several configuration calls \
in one, although it does not give an advantage in terms of speed or anything.  
  Long story:
  
  In fact, I have been experimenting a bit with the daemon.  One of the things that I \
experimented with was to let it execute a script to fix some corner cases (xkbcomp \
+xcape users).  In case the configuration bit is run several times simultaneously we \
can get into some race conditions, so I figured that one needs to compress the calls. \
  Since I don't see why one wouldn't want to compress the calls even without the \
scripting  (what is the point of running xmodmap 5 times in a row with the same \
parameters?) I have proposed this patch. I don't think it adds too much complexity \
and it feels cleaner.

REVISION DETAIL
  https://phabricator.kde.org/D13178

To: jacopods, PHID-PROJ-gqbvozptxawndyihp3hs, hein, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">jacopods added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13178">View Revision</a></tr></table><br \
/><div><div><p>Short story: It just feels more right to me to compress several \
configuration calls in one, although it does not give an advantage in terms of speed \
or anything.</p>

<p>Long story:</p>

<p>In fact, I have been experimenting a bit with the daemon.  One of the things that \
I experimented with was to let it execute a script to fix some corner cases (xkbcomp \
+xcape users).  In case the configuration bit is run several times simultaneously we \
can get into some race conditions, so I figured that one needs to compress the calls. \
<br /> Since I don&#039;t see why one wouldn&#039;t want to compress the calls even \
without the scripting  (what is the point of running xmodmap 5 times in a row with \
the same parameters?) I have proposed this patch. I don&#039;t think it adds too much \
complexity and it feels cleaner.</p></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13178">https://phabricator.kde.org/D13178</a></div></div><br \
/><div><strong>To: </strong>jacopods, Plasma (Plasma 5.13), hein, broulik, drosca<br \
/><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]