[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13148: Allow Kirigami build without KWin tablet mode dependency
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-05-28 12:26:56
Message-ID: 20180528122656.1.762DD1B7E3087B14 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In D13148#269233 <https://phabricator.kde.org/D13148#269233>, @murillobernardes \
wrote:  
  > I did not patch CMakeLists.txt because I can't test it. I could not get a system \
with all the right versions of all build dependencies to build Kirigami.  >
  > On Subsurface-mobile we simply have our own integrated qmake/cmake files that \
builds Kirigami statically with the rest of the project.  
  
  yeah, i know how is done... tough is it a build time or a runtime problem? there is \
an environment variable to force tablet mode alreeady  
  >> Code behaves the same as not having KWin at runtime will result in both values \
being the exact same values as we're doing with this patch  > 
  > So the real issue here is the new dependency on linux. Whatever way we can use to \
disable it is fine.  
  what would make sense, instead a force_tablet_mode , is to make the dependency to \
dbus optional on all platforms

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13148

To: murillobernardes, mart, davidedmundson
Cc: davidedmundson, plasma-devel, apol, mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13148">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D13148#269233" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13148#269233</a>, <a \
href="https://phabricator.kde.org/p/murillobernardes/" style="  border-color: \
#f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@murillobernardes</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I did not patch CMakeLists.txt because I \
can&#039;t test it. I could not get a system with all the right versions of all build \
dependencies to build Kirigami.</p>

<p>On Subsurface-mobile we simply have our own integrated qmake/cmake files that \
builds Kirigami statically with the rest of the project.</p></div> </blockquote>

<p>yeah, i know how is done... tough is it a build time or a runtime problem? there \
is an environment variable to force tablet mode alreeady</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>Code behaves the same as not having KWin at runtime will result in both \
values being the exact same values as we&#039;re doing with this \
patch</p></blockquote>

<p>So the real issue here is the new dependency on linux. Whatever way we can use to \
disable it is fine.</p></blockquote>

<p>what would make sense, instead a force_tablet_mode , is to make the dependency to \
dbus optional on all platforms</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13148">https://phabricator.kde.org/D13148</a></div></div><br \
/><div><strong>To: </strong>murillobernardes, mart, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]