[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       Dominik Haumann <noreply () phabricator ! kde ! org>
Date:       2018-05-27 16:55:27
Message-ID: 20180527165527.1.A11BC276034E915E () phabricator ! kde ! org
[Download RAW message or body]

dhaumann added a comment.


  Looks pretty good to me already. Is there anything that needs to be addressed? What \
do you think about i18nc?

INLINE COMMENTS

> rkflx wrote in Module.cpp:253
> @dhaumann I wonder why you suggested to use `i18n` here too, as `text()` should \
> already give you the translated text. How do you expect translators to translate \
> `"%1 %2"`? 
> The only challenge is to account for RTL languages, but this could be detected to \
> swap the order (and possibly add an RTL BOM?). Do we have experts who could advice \
> on that?

The reason for this is that in a right-to-left language, you would translated "%1 %2" \
by using the reverse, e.g. "%2 %1". The problem here is that a translator will not \
know what to do with this. So what would help is to give translators context, i.g. \
i18nc("reverse order in rtl languages", ...). Does that make sense?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><div><p>Looks pretty good to me already. Is there anything that needs to be \
addressed? What do you think about i18nc?</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-67932">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">Module.cpp:253</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><a \
href="https://phabricator.kde.org/p/dhaumann/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@dhaumann</a> I wonder why you suggested to use <tt \
style="background: #ebebeb; font-size: 13px;">i18n</tt> here too, as <tt \
style="background: #ebebeb; font-size: 13px;">text()</tt> should already give you the \
translated text. How do you expect translators to translate <tt style="background: \
#ebebeb; font-size: 13px;">&quot;%1 %2&quot;</tt>?</p>

<p style="padding: 0; margin: 8px;">The only challenge is to account for RTL \
languages, but this could be detected to swap the order (and possibly add an RTL \
BOM?). Do we have experts who could advice on that?</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The \
reason for this is that in a right-to-left language, you would translated &quot;%1 \
%2&quot; by using the reverse, e.g. &quot;%2 %1&quot;. The problem here is that a \
translator will not know what to do with this. So what would help is to give \
translators context, i.g. i18nc(&quot;reverse order in rtl languages&quot;, ...). \
Does that make sense?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]