[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-05-23 16:56:59
Message-ID: 20180523165659.1.83E4AF9203CE0614 () phabricator ! kde ! org
[Download RAW message or body]

ngraham added inline comments.

INLINE COMMENTS

> Module.cpp:250
> +    if (!ui->nameVersionLabel->isHidden()) {
> +        text += i18n("%1 %2", QStringLiteral("Distro:"), \
> ui->nameVersionLabel->text()) + QStringLiteral("\n"); +    }

Is "Distro" not a translated string?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-67603">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Module.cpp:250</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">ui</span><span style="color: \
#aa2211">-&gt;</span><span class="n">nameVersionLabel</span><span style="color: \
#aa2211">-&gt;</span><span class="n">isHidden</span><span class="p">())</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">text</span> <span style="color: \
#aa2211">+=</span> <span class="n">i18n</span><span class="p">(</span><span \
style="color: #766510">&quot;%1 %2&quot;</span><span class="p">,</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">&quot;Distro:&quot;</span><span class="p">),</span> <span \
class="n">ui</span><span style="color: #aa2211">-&gt;</span><span \
class="n">nameVersionLabel</span><span style="color: #aa2211">-&gt;</span><span \
class="n">text</span><span class="p">())</span> <span style="color: #aa2211">+</span> \
<span class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">&quot;</span><span style="color: #bb6622">\n</span><span style="color: \
#766510">&quot;</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Is &quot;Distro&quot; not a translated \
string?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]