[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11235: [DrKonqi] Request change of ptrace scope from KCrash
From:       Maximiliano Curia <noreply () phabricator ! kde ! org>
Date:       2018-05-22 11:13:07
Message-ID: 20180522111307.1.AB5B8E71B4C0C26B () phabricator ! kde ! org
[Download RAW message or body]

maximilianocuria added inline comments.

INLINE COMMENTS

> queryptrace.cpp:26
> +    server.sun_family = AF_UNIX;
> +    sprintf(server.sun_path, "/tmp/kcrash_%lld", \
> QCoreApplication::applicationPid()); +    if (::connect(sfd, (struct sockaddr \
> *)&server, sl) == 0) {

Please honour TMPDIR or, even better, use QTemporaryDir (this will also make the \
generated path unpredictable), and create the socket inside.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">maximilianocuria added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11235">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11235#inline-67381">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">queryptrace.cpp:26</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">server</span><span class="p">.</span><span class="n">sun_family</span> \
<span style="color: #aa2211">=</span> <span class="n">AF_UNIX</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">sprintf</span><span \
class="p">(</span><span class="n">server</span><span class="p">.</span><span \
class="n">sun_path</span><span class="p">,</span> <span style="color: \
#766510">&quot;/tmp/kcrash_%lld&quot;</span><span class="p">,</span> <span \
class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span \
class="n">applicationPid</span><span class="p">());</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">::</span><span class="n">connect</span><span class="p">(</span><span \
class="n">sfd</span><span class="p">,</span> <span class="p">(</span><span \
style="color: #aa4000">struct</span> <span class="n">sockaddr</span> <span \
style="color: #aa2211">*</span><span class="p">)</span><span style="color: \
#aa2211">&amp;</span><span class="n">server</span><span class="p">,</span> <span \
class="n">sl</span><span class="p">)</span> <span style="color: #aa2211">==</span> \
<span style="color: #601200">0</span><span class="p">)</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Please honour TMPDIR or, even better, use QTemporaryDir (this will also make \
the generated path unpredictable), and create the socket \
inside.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11235">https://phabricator.kde.org/D11235</a></div></div><br \
/><div><strong>To: </strong>croick, Plasma: Workspaces, Frameworks<br /><strong>Cc: \
</strong>maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]