[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12573: Style enhancement for network management applet
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2018-05-02 9:46:29
Message-ID: 20180502094629.1.8F998030ABC7AC03 () phabricator ! kde ! org
[Download RAW message or body]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  imo that's not a thing to be fixed at the applet level, that's how that particular \
plasma theme looks, you can't fix a 3rd party plasma theme by patching applets to not \
follow it.  Probably we new a new standard element for checkbox background, but that \
has to be fixed in base theme and components

REVISION DETAIL
  https://phabricator.kde.org/D12573

To: intika, #plasma, mart
Cc: mart, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (unknown)]

<table><tr><td style="">mart requested changes to this revision.<br />mart added a \
comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12573">View \
Revision</a></tr></table><br /><div><div><p>imo that&#039;s not a thing to be fixed \
at the applet level, that&#039;s how that particular plasma theme looks, you \
can&#039;t fix a 3rd party plasma theme by patching applets to not follow it.<br /> \
Probably we new a new standard element for checkbox background, but that has to be \
fixed in base theme and components</p></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12573">https://phabricator.kde.org/D12573</a></div></div><br \
/><div><strong>To: </strong>intika, Plasma, mart<br /><strong>Cc: </strong>mart, \
zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]