[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12577: Allowing KAMD to run without a database backend
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-04-30 13:55:41
Message-ID: 20180430135541.1.95E401CCD3D78824 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  > ivan created this revision.Sat, Apr 28, 2:06 PM
  > This revision was not accepted when it landed; it landed in state Needs \
Review.Sun, Apr 29, 2:21 PM  
  I don't mind you merging if no-one bothers reviewing your changes, but expecting \
that in 24 hours is a bit ridiculous.  
  Also this commit contains some very irrelevant changes to your commit message \
(removing kde4 migration, plugin loading validation) please try to keep things split.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D12577

To: ivan, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12577">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>ivan created this revision.Sat, Apr 28, 2:06 PM<br /> This revision was \
not accepted when it landed; it landed in state Needs Review.Sun, Apr 29, 2:21 \
PM</p></blockquote>

<p>I don&#039;t mind you merging if no-one bothers reviewing your changes, but \
expecting that in 24 hours is a bit ridiculous.</p>

<p>Also this commit contains some very irrelevant changes to your commit message \
(removing kde4 migration, plugin loading validation) please try to keep things \
split.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R161 KActivity \
Manager Service</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12577">https://phabricator.kde.org/D12577</a></div></div><br \
/><div><strong>To: </strong>ivan, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]