[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12481: Add dptr to models
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-04-30 9:11:07
Message-ID: 20180430091107.1.FFE7AD828119FC9B () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> broulik wrote in models_p.h:26
> Do we need an explicit `Q_DECL_HIDDEN` or something?

No. That's only needed for when people do

class AbstractModel::Private

where AbstractModel is exported

REPOSITORY
  R994 Pulseaudio Qt Bindings

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol, davidedmundson
Cc: davidedmundson, broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added inline comments.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12481">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D12481#inline-63430">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">models_p.h:26</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Do we need an explicit <tt style="background: #ebebeb; font-size: \
13px;">Q_DECL_HIDDEN</tt> or something?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">No. That&#039;s only needed for \
when people do</p>

<p style="padding: 0; margin: 8px;">class AbstractModel::Private</p>

<p style="padding: 0; margin: 8px;">where AbstractModel is \
exported</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R994 Pulseaudio Qt \
Bindings</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>dptr</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12481">https://phabricator.kde.org/D12481</a></div></div><br \
/><div><strong>To: </strong>nicolasfella, drosca, apol, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, broulik, apol, drosca, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]