[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12563: [Run Command] Add closable property so that close button can be disabled.
From:       Dennis Scheffer <noreply () phabricator ! kde ! org>
Date:       2018-04-27 17:43:04
Message-ID: 20180427174304.1.17C1B245EB037729 () phabricator ! kde ! org
[Download RAW message or body]

dscheffer created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dscheffer requested review of this revision.

REVISION SUMMARY
  When using RunCommand.qml, e.g. as part of a plasmoid, it does not always make sense to have \
a close button. This adds a property that makes the element configurable in that sense. The \
closable property's default is 'true' which is equivalent to RunCommand's previous behavior. So \
this change will not break any existing software which uses RunCommand.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12563

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: dscheffer
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">dscheffer created this revision.<br />Restricted Application added a \
project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />dscheffer \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12563">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>When using RunCommand.qml, e.g. as part of a \
plasmoid, it does not always make sense to have a close button. This adds a property that makes \
the element configurable in that sense. The closable property&#039;s default is \
&#039;true&#039; which is equivalent to RunCommand&#039;s previous behavior. So this change \
will not break any existing software which uses RunCommand.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12563">https://phabricator.kde.org/D12563</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>lookandfeel/contents/runcommand/RunCommand.qml</div></div></div><br \
/><div><strong>To: </strong>dscheffer<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]