[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D10079: [Draft] Port baloo krunner plugin to KDBusRunner
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-04-26 15:47:30
Message-ID: 20180426154730.1.8668775C7F5457F3 () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> baloosearchrunner.cpp:79-83
> + // discard any still to-do reply, assuming there is only one instance asking
> + // so quickly in a row, which also currently has no option to repull outdated \
> requests + if (m_matchReply) {
> + m_matchReply->cancel();
> }
You don't need any of this
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10079
To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added inline comments.<br />This revision now requires changes to \
proceed. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10079">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D10079#inline-63958">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">baloosearchrunner.cpp:79-83</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, \
175, .7);"> <span class="bright"></span><span class="n"><span \
class="bright">setDelayedR</span>eply<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span style="color: #304a96"><span \
class="bright">true</span></span><span class="bright"></span><span class="p"><span \
class="bright">);</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> \
<span class="p">(</span><span class="n">m_<span \
class="bright">lastRequest</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">type</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">!=</span></span><span class="bright"> \
</span><span class="n"><span class="bright">QDBusMessage</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">::</span></span><span class="bright"></span><span class="n"><span \
class="bright">InvalidMessage</span></span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);"> <span class="bright"> </span><span class="n"><span \
class="bright">QDBusConnection</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">sessionBus</span></span><span class="bright"></span><span \
class="p"><span class="bright">().</span></span><span class="bright"></span><span \
class="n"><span class="bright">send</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
class="n"><span class="bright">m_lastRequest</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span class="bright">create</span>Reply<span \
class="bright"></span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span class="n"><span \
class="bright">QVariantList</span></span><span class="bright"></span><span \
class="p"><span class="bright">())</span>);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="bright"></span><span style="color: #74777d"><span class="bright">// discard \
any still to-do r</span>eply<span class="bright">, assuming there is only one \
instance asking</span></span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span \
style="color: #74777d"><span class="bright">// so quickly in a row, which also \
currently has no option to repull outdated requests</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_<span \
class="bright">matchReply</span></span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span \
class="bright">m_match</span>Reply<span class="bright"></span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">-></span></span><span class="bright"></span><span class="n"><span \
class="bright">cancel</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span>);</span> </div><div style="padding: 0 8px; margin: 0 4px; "> \
<span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
don't need any of this</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10079">https://phabricator.kde.org/D10079</a></div></div><br \
/><div><strong>To: </strong>kossebau, davidedmundson, broulik, mart<br /><strong>Cc: \
</strong>michaelh, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic