[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12536: [timer applet] Change how time is tracked
From:       Mariusz Mazur <noreply () phabricator ! kde ! org>
Date:       2018-04-26 13:34:44
Message-ID: 20180426133444.1.88B6BC09500D66F8 () phabricator ! kde ! org
[Download RAW message or body]

mmazur added a comment.


  In D12536#254280 <https://phabricator.kde.org/D12536#254280>, @davidedmundson \
wrote:  
  > > I was hoping the reviewer wouldn't notice.
  >
  > :/
  >  Had you said it explicitly I probably would have been fine with it.
  
  
  I'm operating on the assumption that working code with some changes to behavior > \
non-working code. Consequently I was trying to get my patches merged above any other \
considerations and with minimal time investment on my part. (Granted, I would have \
done things a bit differently knowing what I know now. :)  
  Though come to think of it, there is a simple workaround I could add: if the time \
jump exceeds 60 seconds, assume the system was asleep for long enough, that the timer \
should be treated as paused. Still – it's a workaround and not a proper fix.  
  >> As far as interacting with me goes, it's either merge my code with minor \
improvements here and there  > 
  > I understand your time is limited, but lets not approach things as effectively \
threats.  
  Considering time constraints, my goal was to concisely communicate my priorities \
and limitations. Now that you understand those, I'm waiting to know how you'd like to \
proceed on this patch and the other one.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12536

To: mmazur, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">mmazur added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12536">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D12536#254280" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D12536#254280</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>I was hoping the reviewer wouldn&#039;t \
notice.</p></blockquote>

<p>:/<br />
 Had you said it explicitly I probably would have been fine with it.</p></div>
</blockquote>

<p>I&#039;m operating on the assumption that working code with some changes to \
behavior &gt; non-working code. Consequently I was trying to get my patches merged \
above any other considerations and with minimal time investment on my part. (Granted, \
I would have done things a bit differently knowing what I know now. :)</p>

<p>Though come to think of it, there is a simple workaround I could add: if the time \
jump exceeds 60 seconds, assume the system was asleep for long enough, that the timer \
should be treated as paused. Still – it&#039;s a workaround and not a proper \
fix.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>As far as interacting with me goes, it&#039;s either merge my code with \
minor improvements here and there</p></blockquote>

<p>I understand your time is limited, but lets not approach things as effectively \
threats.</p></blockquote>

<p>Considering time constraints, my goal was to concisely communicate my priorities \
and limitations. Now that you understand those, I&#039;m waiting to know how \
you&#039;d like to proceed on this patch and the other one.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12536">https://phabricator.kde.org/D12536</a></div></div><br \
/><div><strong>To: </strong>mmazur, Plasma, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]